hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hornn <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: HAWQ-462. Adding dfs_address from pgf...
Date Fri, 04 Mar 2016 20:13:07 GMT
Github user hornn commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/412#discussion_r55082603
  
    --- Diff: src/backend/access/external/hd_work_mgr.c ---
    @@ -783,6 +786,10 @@ make_allocation_output_string(List *segment_fragments)
     		appendStringInfoChar(&fragment_str, SEGWORK_IN_PAIR_DELIM);
     		if (frag->fragment_md)
     			appendStringInfo(&fragment_str, "%s", frag->fragment_md);
    +		/* Adding dfs_address from pg_filespace entry required for HAWQ-462 */
    +		appendStringInfoChar(&fragment_str, SEGWORK_IN_PAIR_DELIM);
    +		if (dfs_address)
    --- End diff --
    
    why do we need to pass this value for each fragment? wouldn't it be better to pass it
just once, perhaps append it in the end of the segments string (after the loop)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message