hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hornn <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request:
Date Wed, 02 Mar 2016 02:18:18 GMT
Github user hornn commented on the pull request:

    https://github.com/apache/incubator-hawq/commit/495bb2a2b264da533be237d312507d5e97faec53#commitcomment-16435206
  
    In src/bin/gpfusion/gpbridgeapi.c:
    In src/bin/gpfusion/gpbridgeapi.c on line 518:
    I don't know if the filespace info is available from the segment or not - but from your
description it sounds like it's not.
    
    In that case, I think the solution might be to propagate the dfs_url from the master to
the segment as part of the external scan info. For readable table it should be easy - the
data can be added in hd_work_mgr, together with the fragments info. For writable tables it's
more tricky, because there is no pxf-specific code that is called in the master for writable
tables. So I think a better solution would be to always make this info available to external
protocol code, by making it part of the external scan, or perhaps populating a global variable
when the segment starts.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message