Return-Path: X-Original-To: apmail-hawq-dev-archive@minotaur.apache.org Delivered-To: apmail-hawq-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1C6EF18815 for ; Fri, 19 Feb 2016 04:00:10 +0000 (UTC) Received: (qmail 51123 invoked by uid 500); 19 Feb 2016 03:59:45 -0000 Delivered-To: apmail-hawq-dev-archive@hawq.apache.org Received: (qmail 51081 invoked by uid 500); 19 Feb 2016 03:59:45 -0000 Mailing-List: contact dev-help@hawq.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hawq.incubator.apache.org Delivered-To: mailing list dev@hawq.incubator.apache.org Received: (qmail 50754 invoked by uid 99); 19 Feb 2016 03:59:41 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 Feb 2016 03:59:41 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 09E8C1A031B for ; Fri, 19 Feb 2016 03:59:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.349 X-Spam-Level: X-Spam-Status: No, score=-4.349 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.329] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id aszGlq9pnXSs for ; Fri, 19 Feb 2016 03:59:01 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id 81E055F5CB for ; Fri, 19 Feb 2016 03:59:00 +0000 (UTC) Received: (qmail 37628 invoked by uid 99); 19 Feb 2016 03:52:31 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 Feb 2016 03:52:31 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 1F100E0231; Fri, 19 Feb 2016 03:52:31 +0000 (UTC) From: ictmalili To: dev@hawq.incubator.apache.org Reply-To: dev@hawq.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-hawq pull request: HAWQ-275. Add connection check when d... Content-Type: text/plain Message-Id: <20160219035231.1F100E0231@git1-us-west.apache.org> Date: Fri, 19 Feb 2016 03:52:31 +0000 (UTC) Github user ictmalili commented on the pull request: https://github.com/apache/incubator-hawq/pull/357#issuecomment-186040416 Yes, function executormgr_validate_conn and dispatcherAYT have repeated code, but I'm not sure whether we can merge the two functions into one since dispatcherAYT is in ic_udp.c and interconnect seems a independent part. Shall we merge that? @changleicn --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---