Mailing-List: contact dev-help@hawq.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hawq.incubator.apache.org
From: GodenYao <git@git.apache.org>
To: dev@hawq.incubator.apache.org
Reply-To: dev@hawq.incubator.apache.org
References: <git-pr-347-incubator-hawq@git.apache.org>
In-Reply-To: <git-pr-347-incubator-hawq@git.apache.org>
Subject: [GitHub] incubator-hawq pull request: HAWQ-400. Support expected exit
 codes...
Content-Type: text/plain
Message-Id: <20160217191202.9C14EE0092@git1-us-west.apache.org>
Date: Wed, 17 Feb 2016 19:12:02 +0000 (UTC)

Github user GodenYao commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/347#discussion_r53214666
  
    --- Diff: src/test/regress/pg_regress.c ---
    @@ -1672,19 +1800,9 @@ run_single_test(const char *test, test_function tfunc)
     		differ |= newdiff;
     	}
     
    -	if (differ)
    -	{
    -		status(_("FAILED"));
    -		fail_count++;
    -	}
    -	else
    -	{
    -		status(_("ok"));
    -		success_count++;
    -	}
    +	int expected_status = get_expected_status(test);
     
    -	if (exit_status != 0)
    -		log_child_failure(exit_status);
    +	print_test_status(differ, exit_status, expected_status, -1);
    --- End diff --
    
    -1? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---