Return-Path: X-Original-To: apmail-hawq-dev-archive@minotaur.apache.org Delivered-To: apmail-hawq-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 93D971879F for ; Wed, 3 Feb 2016 08:26:52 +0000 (UTC) Received: (qmail 58773 invoked by uid 500); 3 Feb 2016 08:26:49 -0000 Delivered-To: apmail-hawq-dev-archive@hawq.apache.org Received: (qmail 58715 invoked by uid 500); 3 Feb 2016 08:26:49 -0000 Mailing-List: contact dev-help@hawq.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hawq.incubator.apache.org Delivered-To: mailing list dev@hawq.incubator.apache.org Received: (qmail 58700 invoked by uid 99); 3 Feb 2016 08:26:49 -0000 Received: from Unknown (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Feb 2016 08:26:49 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id DEAB11A034E for ; Wed, 3 Feb 2016 08:26:48 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -2.921 X-Spam-Level: X-Spam-Status: No, score=-2.921 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_BRBL_LASTEXT=1.644, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.545] autolearn=disabled Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id hkap1LHBzOZo for ; Wed, 3 Feb 2016 08:26:48 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with SMTP id EB8EC21150 for ; Wed, 3 Feb 2016 08:26:46 +0000 (UTC) Received: (qmail 58696 invoked by uid 99); 3 Feb 2016 08:26:46 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Feb 2016 08:26:46 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 118D3DFC8F; Wed, 3 Feb 2016 08:26:46 +0000 (UTC) From: 0x0FFF To: dev@hawq.incubator.apache.org Reply-To: dev@hawq.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-hawq pull request: [HAWQ-19] Money type overflow fixed b... Content-Type: text/plain Message-Id: <20160203082646.118D3DFC8F@git1-us-west.apache.org> Date: Wed, 3 Feb 2016 08:26:46 +0000 (UTC) Github user 0x0FFF commented on the pull request: https://github.com/apache/incubator-hawq/pull/323#issuecomment-179084818 Speaking about this specific case: do we plan an upgrade path from HAWQ 1.x to 2.0? If no, then this PR can be easily merged into 2.0. If yes, we should really care about the upgrade path, and maybe the better solution here would be the following: instead of changing existing data type introduce new one, like "money8" for 8-byte money data type. This would again be a catalog change (for example, in pg_type), but still won't affect the customers using old data type "money" and layout of their existing tables Generally speaking, I agree that this is a tough question. Postgres is not a very good example here - you can easily do pg_dump and pg_restore there as the data volumes it operates with are usually quite small. As of HAWQ, making dump and restore to accommodate storage format change can't be an option as we might have hundreds of TB there. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---