Mailing-List: contact dev-help@hawq.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hawq.incubator.apache.org
From: adamjshook <git@git.apache.org>
To: dev@hawq.incubator.apache.org
Reply-To: dev@hawq.incubator.apache.org
References: <git-pr-302-incubator-hawq@git.apache.org>
In-Reply-To: <git-pr-302-incubator-hawq@git.apache.org>
Subject: [GitHub] incubator-hawq pull request: HAWQ-178: Add JSON plugin
 support in ...
Content-Type: text/plain
Message-Id: <20160201173133.1DF10DFE61@git1-us-west.apache.org>
Date: Mon,  1 Feb 2016 17:31:33 +0000 (UTC)

Github user adamjshook commented on the pull request:

    https://github.com/apache/incubator-hawq/pull/302#issuecomment-178085903
  
    Good to hear from you as well Christian :)
    
    I think you're right on the `identifier `as the means to have an end-tag and new-tag.  It's slowly coming back.  The `StreamReader `seeks until it finds the identifier, then flushes the `StringBuilder` and appends characters until the final end brace is met, accounting for any nested begin brace/end brace combinations.  The big problem that happens is if the identifier is embedded as a string inside a JSON record, it would create an incomplete record.  If your identifier was `record` in the below example where the split is the horizontal line, bad stuff would happen.  This is why the expectation was one file = one split.
    
    ```
    record : {
    --------------------------
        text : "this is a record"
    }
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---