hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From xinzweb <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: HAWQ-455. Disable creating partition ...
Date Mon, 29 Feb 2016 18:00:01 GMT
Github user xinzweb commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/387#discussion_r54449367
  
    --- Diff: src/backend/parser/analyze.c ---
    @@ -2986,6 +2986,27 @@ transformDistributedBy(ParseState *pstate, CreateStmtContext *cxt,
     
     	*policyp = policy;
     
    +	if (cxt && cxt->inhRelations)
    +	{
    +		ListCell   *entry;
    +
    +		foreach(entry, cxt->inhRelations)
    +		{
    +			RangeVar   *parent = (RangeVar *) lfirst(entry);
    +			Oid			relId = RangeVarGetRelid(parent, false, false /*allowHcatalog*/);
    --- End diff --
    
    Do you also want to comment on `false` as `false /*failOK*/` for easier code reading?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message