hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From liming01 <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: HAWQ-386. Remove deprecated catalog t...
Date Thu, 18 Feb 2016 04:15:17 GMT
Github user liming01 commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/322#discussion_r53269798
  
    --- Diff: tools/bin/hawqpylib/system/configurationImplHAWQ.py ---
    @@ -276,12 +271,8 @@ def __updateSystemConfigUpdateSegment(self, conn, hawqArray, seg,
originalSeg, t
             # update mode and status
             # when adding a mirror, the replication port may change as well
             #
    -        if hawqArray.getFaultStrategy() == hawqarray.FAULT_STRATEGY_NONE:
    -            what = "%s: segment hostname and address"
    -            self.__updateSegmentAddress(conn, seg)
    -        else:
    -            what = "%s: segment mode and status"
    -            self.__updateSegmentModeStatus(conn, seg)
    --- End diff --
    
    From the hawq1.x doc, it seems 3 types fault_strategy can be set: nothing / file-based
failover / SAN-based failover.
    Now we remove this catalog, it means we only have one choice, is it the 'nothing' setting
left? 
    so here in the code, you may keep the wrong branch in the if-else statement. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message