hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shivzone <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: HAWQ-400. Support expected exit codes...
Date Wed, 17 Feb 2016 01:12:16 GMT
Github user shivzone commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/347#discussion_r53107862
  
    --- Diff: src/test/regress/GNUmakefile ---
    @@ -143,7 +143,7 @@ installcheck-parallel: all upg2-setup ugpart-setup
     	$(pg_regress_call)  --psqldir=$(PSQLDIR) --schedule=$(srcdir)/parallel_schedule --srcdir=$(abs_srcdir)
     
     installcheck-good: all ./current_good_schedule upg2-setup ugpart-setup
    -	$(pg_regress_call)  --psqldir=$(PSQLDIR) --schedule=./current_good_schedule --srcdir=$(abs_srcdir)
    +	$(pg_regress_call)  --psqldir=$(PSQLDIR) --schedule=./current_good_schedule --srcdir=$(abs_srcdir)
--expected-statuses-file=expected_statuses
    --- End diff --
    
    can we instead call it expected-status-file. it will be implicit that this file will contain
one status for each test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message