hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From liming01 <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: [HAWQ-19] Money type overflow fixed b...
Date Mon, 15 Feb 2016 11:35:45 GMT
Github user liming01 commented on the pull request:

    https://github.com/apache/incubator-hawq/pull/323#issuecomment-184176240
  
    Cool! 
    
    BTW, There are 2 points here:
    (1) It seems we need to add meta info for functions you added(e.g. int8_mul_cash() ) into
below files:
    apache-hawq/src/backend/utils/fmgrtab.c
    apache-hawq/src/include/catalog/pg_operator.h
    apache-hawq/src/include/catalog/pg_proc.h 
    
    (2) I saw you changed argument type to int64 for function cash_div_int4(), but didn't
change for fucntion 
    cash_div_int2(). I guess you may want to fix the problem caused by (1) point above. So
please revert this change. It may cause the result precision.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message