hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hornn <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: HAWQ-405. Fix for handling of pg_temp...
Date Thu, 11 Feb 2016 00:07:06 GMT
Github user hornn commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/338#discussion_r52548075
  
    --- Diff: src/test/regress/expected/temp.out ---
    @@ -170,3 +170,19 @@ select * from whereami;
     -- you can invoke a temp function explicitly, though
     -- select pg_temp.whoami();
     drop table public.whereami;
    +create temp table temptest (row integer, count integer);
    --- End diff --
    
    I think it would be better to have the exact scenario that failed:
    ```
    CREATE TABLE pg_temp.temptest ...
    SELECT avg(pg_temp.temptest.count) ... 
    ```
    Do you think we should cover all three cases (db.table.col, table.col, col)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message