hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GodenYao <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: HAWQ-405. Fix for handling of pg_temp...
Date Wed, 10 Feb 2016 22:09:35 GMT
Github user GodenYao commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/338#discussion_r52534179
  
    --- Diff: src/backend/catalog/namespace.c ---
    @@ -1495,18 +1495,34 @@ LookupInternalNamespaceId(const char *nspname)
     Oid
     LookupNamespaceId(const char *nspname, Oid dboid)
     {
    -    if(gp_upgrade_mode){
    +
    +	/* check for pg_temp alias */
    +	if (NSPDBOID_CURRENT == dboid && strcmp(nspname, "pg_temp") == 0)
    +	{
    +		if (TempNamespaceValid(true))
    +			return myTempNamespace;
    +		/*
    +		 * Since this is used only for looking up existing objects, there
    +		 * is no point in trying to initialize the temp namespace here;
    +		 * and doing so might create problems for some callers.
    +		 * Just fall through and give the "does not exist" error.
    +		 */
    +	}
    +
    +    if(gp_upgrade_mode)
    --- End diff --
    
    I am thinking we may be able to remove the entire if(gp_upgrade_mode), as there's no upgrade
path from previous Pivotal commercial 1.3.x HAWQ to 2.0 (only way is to do data reloading).
    So this logic probably is no longer needed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message