hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From 0x0FFF <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: [HAWQ-19] Money type overflow fixed b...
Date Thu, 04 Feb 2016 12:16:31 GMT
Github user 0x0FFF commented on the pull request:

    https://github.com/apache/incubator-hawq/pull/323#issuecomment-179796519
  
    As of HAWQ inputformat, it never [supported "money" datatype](https://github.com/apache/incubator-hawq/blob/master/contrib/hawq-hadoop/hawq-mapreduce-common/src/main/java/com/pivotal/hawq/mapreduce/schema/HAWQPrimitiveField.java#L33):
    
    ```java
    /**
     * Enumeration of all supported primitive type.
     * Note that CHAR and BPCHAR are the same, we include BPCHAR for internal usage.
     */
    public static enum PrimitiveType {
    	BOOL, BIT, VARBIT, BYTEA, INT2, INT4, INT8, FLOAT4, FLOAT8, NUMERIC,
    	CHAR, BPCHAR, VARCHAR, TEXT, DATE, TIME, TIMETZ, TIMESTAMP, TIMESTAMPTZ, INTERVAL,
    	POINT, LSEG, BOX, CIRCLE, PATH, POLYGON, MACADDR, INET, CIDR, XML
    }
    ```
    We can add it, but I think it should be a separate PR
    Also it would be nice to port other "cash" functions from postgres, allowing convertation
of numeric, int and float to money


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message