hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hornn <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: HAWQ-178: Add JSON plugin support in ...
Date Thu, 04 Feb 2016 06:29:11 GMT
Github user hornn commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/302#discussion_r51834454
  
    --- Diff: pxf/pxf-json/src/main/java/org/apache/hawq/pxf/plugins/json/parser/PartitionedJsonParser.java
---
    @@ -0,0 +1,198 @@
    +package org.apache.hawq.pxf.plugins.json.parser;
    +
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + * 
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + * 
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +
    +import java.io.IOException;
    +import java.io.InputStream;
    +import java.io.InputStreamReader;
    +import java.nio.charset.StandardCharsets;
    +import java.util.ArrayList;
    +import java.util.EnumSet;
    +import java.util.List;
    +
    +import org.apache.hawq.pxf.plugins.json.parser.JsonLexer.JsonLexerState;
    +
    +/**
    + * A simple parser that can support reading JSON objects from a random point in JSON
text. It reads from the supplied
    + * stream (which is assumed to be positioned at any arbitrary position inside some JSON
text) until it find the first
    + * JSON begin-object "{". From this point on it will keep reading JSON objects until
it finds one containing a member
    + * string that the user supplies.
    + * <p/>
    + * It is not recommended to use this with JSON text where individual JSON objects that
can be large (MB's or larger).
    + */
    +public class PartitionedJsonParser {
    +
    +	private static final int EOF = -1;
    +	private final InputStreamReader inputStreamReader;
    +	private final JsonLexer lexer;
    +	private long bytesRead = 0;
    +	private boolean endOfStream;
    --- End diff --
    
    for clarify, perhaps explicitly assign `false` to it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message