hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hornn <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: HAWQ-369. Hcatalog as reserved name.
Date Wed, 03 Feb 2016 00:16:14 GMT
Github user hornn commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/324#discussion_r51659823
  
    --- Diff: src/test/regress/input/hcatalog_lookup.source ---
    @@ -138,16 +138,49 @@ alter table test_schema.p exchange partition p1 with table hcatalog.test_schema.
     select pg_catalog.pg_database_size('hcatalog');
     select pg_catalog.pg_database_size(6120);
     
    +--positive test: should be able to create table named "hcatalog"
    +CREATE TABLE hcatalog(a int);
    +
    +--negative test: cannot create database named "hcatalog"
    +CREATE DATABASE hcatalog;
    +
    +--allow renaming schemas and databases
    +SET gp_called_by_pgdump = true;
    +
    +--negative test: cannot rename existing database to "hcatalog"
    +ALTER DATABASE regression RENAME TO hcatalog;
    +
    +--positive test: can rename existing schema to "hcatalog"
    +CREATE SCHEMA test_schema3;
    +ALTER SCHEMA test_schema3 RENAME to hcatalog;
    +
    +--positive test: can rename schema "hcatalog"
    +ALTER SCHEMA hcatalog RENAME to hcatalog1;
    +
    +--positive test: should be able to create schema named "hcatalog"
    +CREATE SCHEMA hcatalog;
    +
    +--negative test: cannot create a database using "hcatalog" as a template
    +CREATE DATABASE hcatalog2 TEMPLATE hcatalog;
    +
    +--restrict renaming schemas and databases
    +SET gp_called_by_pgdump = false;
    +
     -- cleanup
     DROP schema test_schema cascade;
     SELECT convert_to_internal_schema('test_schema');
     DROP schema test_schema cascade;
     DROP schema test_schema2 cascade;
    +DROP schema hcatalog1 cascade;
    --- End diff --
    
    missing drop for hcatalog schema


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message