hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sansanichfb <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: HAWQ-369. Hcatalog as reserved name.
Date Tue, 02 Feb 2016 23:08:08 GMT
Github user sansanichfb commented on a diff in the pull request:

    --- Diff: src/test/regress/input/hcatalog_lookup.source ---
    @@ -138,16 +138,51 @@ alter table test_schema.p exchange partition p1 with table hcatalog.test_schema.
     select pg_catalog.pg_database_size('hcatalog');
     select pg_catalog.pg_database_size(6120);
    +--positive test: should be able to create table named "hcatalog"
    +CREATE TABLE hcatalog(a int);
    +--negative test: cannot create database named "hcatalog"
    +CREATE DATABASE hcatalog;
    +--allow renaming schemas and databases
    +SET gp_called_by_pgdump = true;
    +--negative test: cannot rename exiting database to "hcatalog"
    +ALTER DATABASE regression RENAME TO hcatalog;
    +--positive test: can rename exiting schema to "hcatalog"
    +CREATE SCHEMA test_schema3;
    +ALTER SCHEMA test_schema3 RENAME to hcatalog;
    +ALTER SCHEMA hcatalog RENAME to hcatalog1;
    +--positive test: should be able to create schema named "hcatalog"
    +CREATE SCHEMA hcatalog;
    +--positive test: can rename schema "hcatalog"
    +ALTER SCHEMA hcatalog RENAME to hcatalog2;
    +--negative test: cannot create a database using "hcatalog" as a template
    +CREATE DATABASE hcatalog2 TEMPLATE hcatalog;
    --- End diff --
    correct, just added positive case to ensure 

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message