hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From huor <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: HAWQ-376. Fixed QE core dump at HdfsC...
Date Tue, 02 Feb 2016 02:46:39 GMT
Github user huor commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/312#discussion_r51515926
  
    --- Diff: src/backend/storage/file/fd.c ---
    @@ -632,33 +632,54 @@ LruDelete(File file)
     	if (vfdP->seekPos == INT64CONST(-1))
     		elog(ERROR, "could not get the current position of file \"%s\": %m", vfdP->fileName);
     
    -	/* close the file */
    -	if (IsLocalPath(VfdCache[file].fileName))
    -	{
    -		if (close(vfdP->fd))
    -			elog(ERROR, "could not close file \"%s\": %m", vfdP->fileName);
    -	}
    +	// Need to firstly remove file description from VfdCache before closing file,
    --- End diff --
    
    For multiple line comment, use
    /**
     * xxx
     */


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message