Mailing-List: contact dev-help@hawq.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hawq.incubator.apache.org
From: hornn <git@git.apache.org>
To: dev@hawq.incubator.apache.org
Reply-To: dev@hawq.incubator.apache.org
References: <git-pr-302-incubator-hawq@git.apache.org>
In-Reply-To: <git-pr-302-incubator-hawq@git.apache.org>
Subject: [GitHub] incubator-hawq pull request: HAWQ-178: Add JSON plugin
 support in ...
Content-Type: text/plain
Message-Id: <20160129005436.BD76FDFF96@git1-us-west.apache.org>
Date: Fri, 29 Jan 2016 00:54:36 +0000 (UTC)

Github user hornn commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/302#discussion_r51212745
  
    --- Diff: pxf/pxf-json/src/main/java/org/apache/hawq/pxf/plugins/json/JsonAccessor.java ---
    @@ -0,0 +1,66 @@
    +package org.apache.hawq.pxf.plugins.json;
    +
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + * 
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + * 
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +
    +import java.io.IOException;
    +
    +import org.apache.commons.lang3.StringUtils;
    +import org.apache.hadoop.mapred.FileSplit;
    +import org.apache.hadoop.mapred.InputSplit;
    +import org.apache.hadoop.mapred.JobConf;
    +import org.apache.hawq.pxf.api.utilities.InputData;
    +import org.apache.hawq.pxf.plugins.hdfs.HdfsSplittableDataAccessor;
    +
    +/**
    + * This JSON accessor for PXF will read JSON data and pass it to a {@link JsonResolver}.
    + * 
    + * This accessor supports a single JSON record per line, or a more "pretty print" format.
    + */
    +public class JsonAccessor extends HdfsSplittableDataAccessor {
    +
    +	public static final String IDENTIFIER_PARAM = "IDENTIFIER";
    +	public static final String ONERECORDPERLINE_PARAM = "ONERECORDPERLINE";
    +
    +	private String identifier = "";
    +	private boolean oneRecordPerLine = true;
    +
    +	public JsonAccessor(InputData inputData) throws Exception {
    +		super(inputData, new JsonInputFormat());
    +
    +		if (!StringUtils.isEmpty(inputData.getUserProperty(IDENTIFIER_PARAM))) {
    +			identifier = inputData.getUserProperty(IDENTIFIER_PARAM);
    --- End diff --
    
    is it ok not to have an identifier? what happens if we leave it as ""?
    If it's an error, it should probably be handled here by throwing an exception.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---