Return-Path: X-Original-To: apmail-hawq-dev-archive@minotaur.apache.org Delivered-To: apmail-hawq-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1397818258 for ; Mon, 18 Jan 2016 17:29:37 +0000 (UTC) Received: (qmail 77382 invoked by uid 500); 18 Jan 2016 17:29:34 -0000 Delivered-To: apmail-hawq-dev-archive@hawq.apache.org Received: (qmail 77339 invoked by uid 500); 18 Jan 2016 17:29:34 -0000 Mailing-List: contact dev-help@hawq.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hawq.incubator.apache.org Delivered-To: mailing list dev@hawq.incubator.apache.org Received: (qmail 77101 invoked by uid 99); 18 Jan 2016 17:29:34 -0000 Received: from Unknown (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 Jan 2016 17:29:34 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 131B01A054B for ; Mon, 18 Jan 2016 17:29:34 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.427 X-Spam-Level: X-Spam-Status: No, score=0.427 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.554, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id aXCbKWi9U_E6 for ; Mon, 18 Jan 2016 17:29:26 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with SMTP id 461E320270 for ; Mon, 18 Jan 2016 17:29:25 +0000 (UTC) Received: (qmail 75562 invoked by uid 99); 18 Jan 2016 17:29:24 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 Jan 2016 17:29:24 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 64359E03CD; Mon, 18 Jan 2016 17:29:24 +0000 (UTC) From: craig-chasseur To: dev@hawq.incubator.apache.org Reply-To: dev@hawq.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-hawq pull request: HAWQ-307. Ubuntu Support Content-Type: text/plain Message-Id: <20160118172924.64359E03CD@git1-us-west.apache.org> Date: Mon, 18 Jan 2016 17:29:24 +0000 (UTC) Github user craig-chasseur commented on the pull request: https://github.com/apache/incubator-hawq/pull/250#issuecomment-172599173 Mostly LGTM, but I had a small suggestion about simplifying GCC version detection. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---