Return-Path: X-Original-To: apmail-hawq-dev-archive@minotaur.apache.org Delivered-To: apmail-hawq-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 118A718E82 for ; Tue, 5 Jan 2016 07:19:56 +0000 (UTC) Received: (qmail 70202 invoked by uid 500); 5 Jan 2016 07:19:56 -0000 Delivered-To: apmail-hawq-dev-archive@hawq.apache.org Received: (qmail 70150 invoked by uid 500); 5 Jan 2016 07:19:56 -0000 Mailing-List: contact dev-help@hawq.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hawq.incubator.apache.org Delivered-To: mailing list dev@hawq.incubator.apache.org Received: (qmail 70139 invoked by uid 99); 5 Jan 2016 07:19:55 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Jan 2016 07:19:55 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 4F171C1627 for ; Tue, 5 Jan 2016 07:19:55 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.98 X-Spam-Level: X-Spam-Status: No, score=0.98 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id ZQirq3S7IV24 for ; Tue, 5 Jan 2016 07:19:46 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with SMTP id D707723120 for ; Tue, 5 Jan 2016 07:19:45 +0000 (UTC) Received: (qmail 70002 invoked by uid 99); 5 Jan 2016 07:19:44 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Jan 2016 07:19:44 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id C56FBDFE5F; Tue, 5 Jan 2016 07:19:44 +0000 (UTC) From: wangzw To: dev@hawq.incubator.apache.org Reply-To: dev@hawq.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-hawq pull request: HAWQ-316. Rework SSE42 implementation... Content-Type: text/plain Message-Id: <20160105071944.C56FBDFE5F@git1-us-west.apache.org> Date: Tue, 5 Jan 2016 07:19:44 +0000 (UTC) Github user wangzw commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/242#discussion_r48817999 --- Diff: src/bin/gpupgrade/gpmodcatversion.c --- @@ -174,19 +174,20 @@ main(int argc, char *argv[]) } /* Check the CRC. */ - crc = crc32c(crc32cInit(), &ControlFile, offsetof(ControlFileData, crc)); - crc32cFinish(crc); + INIT_CRC32C(crc); --- End diff -- please fix indent issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---