hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cwelton <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: HAWQ-307. Ubuntu Support
Date Sat, 30 Jan 2016 04:05:18 GMT
Github user cwelton commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/250#discussion_r51340004
  
    --- Diff: src/backend/resourcemanager/communication/rmcomm_QD2RM.c ---
    @@ -2145,7 +2145,7 @@ int findFile(const char *filename)
     int createFile(const char *filename)
     {
     	int fd = 0;
    -	fd = open(filename, O_RDWR|O_CREAT);
    +	fd = open(filename, O_RDWR|O_CREAT, S_IRUSR | S_IWUSR);
    --- End diff --
    
    The S_IRUSR and S_IWUSR flags indicate that the file should be created with the u+rw permission
bits set, presumably default permissions were different between Ubuntu and CentOS and switching
to the three parameter open() call is more explicit in the behavior.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message