hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From huor <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: HAWQ-365. Improve DEBUG level log for...
Date Wed, 27 Jan 2016 03:54:15 GMT
Github user huor commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/298#discussion_r50938558
  
    --- Diff: src/backend/resourcemanager/resqueuemanager.c ---
    @@ -2142,8 +2142,10 @@ int registerConnectionByUserID(ConnectionTrack  conntrack,
     
     	transformConnectionTrackProgress(conntrack, CONN_PP_REGISTER_DONE);
     
    -	elog(LOG, "ConnID %d. Connection is registered.", conntrack->ConnID);
    -
    +	elog(DEBUG3, "Resource queue %s has %d connections after registering "
    +				 "connection.",
    +				 queuetrack->QueueInfo->Name,
    +				 queuetrack->CurConnCounter);
    --- End diff --
    
    It it better to add current ConnID here:
    elog(DEBUG3, "Resource queue %s has %d connections after registering "
                                                   "connection ConnID %d.",
                                                   queuetrack->QueueInfo->Name,
                                                   queuetrack->CurConnCounter,
                                                   conntrack->ConnID);


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message