hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shivzone <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: HAWQ-340. Make getVersion API return ...
Date Mon, 25 Jan 2016 23:07:22 GMT
Github user shivzone commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/290#discussion_r50771928
  
    --- Diff: pxf/pxf-service/src/test/java/org/apache/hawq/pxf/service/rest/VersionResourceTest.java
---
    @@ -22,21 +22,26 @@
     
     import static org.junit.Assert.assertEquals;
     
    +import javax.ws.rs.core.HttpHeaders;
    +import javax.ws.rs.core.MediaType;
     import javax.ws.rs.core.Response;
     
     import org.junit.Test;
     
     public class VersionResourceTest {
     
    -    @Test
    -    public void getProtocolVersion() throws Exception {
    +	@Test
    +	public void getProtocolVersion() throws Exception {
     
    -        VersionResource resource = new VersionResource();
    -        Response result = resource.getProtocolVersion();
    +		VersionResource resource = new VersionResource();
    --- End diff --
    
    Fix your indentation to 4 space instead of 8 space


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message