hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From huor <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: HAWQ-362. Master RM should Recalculat...
Date Mon, 25 Jan 2016 02:37:02 GMT
Github user huor commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/291#discussion_r50649995
  
    --- Diff: src/backend/resourcemanager/resourcepool.c ---
    @@ -893,6 +893,28 @@ int addHAWQSegWithSegStat(SegStat segstat, bool *capstatchanged)
     	else {
     		segresource = getSegResource(segid);
     		Assert(segresource != NULL);
    +		uint8_t oldStatus = segresource->Stat->FTSAvailable;
    +		bool statusChanged = oldStatus != segstat->FTSAvailable;
    +
    +		/* Check if RM process is restarted in this segment */
    +		if (segresource->Stat->RMStartTimestamp != segstat->RMStartTimestamp)
    --- End diff --
    
    A comment here to illustrate the idea would be better. It is also good to mention the
risk that below three condition hold:
    1. rmseg reset
    2. system time reset on segment node
    3. segresource->Stat->RMStartTimestamp == segstat->RMStartTimestamp


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message