hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mithmatt <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: HAWQ-340. Make getVersion API return ...
Date Sat, 23 Jan 2016 00:07:26 GMT
Github user mithmatt commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/290#discussion_r50607911
  
    --- Diff: pxf/pxf-service/src/test/java/org/apache/hawq/pxf/service/rest/VersionResourceTest.java
---
    @@ -36,7 +36,7 @@ public void getProtocolVersion() throws Exception {
     
             assertEquals(Response.Status.OK,
                     Response.Status.fromStatusCode(result.getStatus()));
    -        assertEquals("PXF protocol version " + Version.PXF_PROTOCOL_VERSION,
    +        assertEquals("{ \"version\": \"" + Version.PXF_PROTOCOL_VERSION + "\"}",
    --- End diff --
    
    Do you think an additional assert statement is required for MediaType to see if it is
APPLICATION_JSON_TYPE?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message