hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hornn <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: Hawq 317
Date Tue, 19 Jan 2016 20:55:26 GMT
Github user hornn commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/279#discussion_r50173781
  
    --- Diff: src/backend/cdb/cdbquerycontextdispatching.c ---
    @@ -2872,31 +2872,27 @@ static char* GetExtTableFirstLocation(Datum *array)
      * Using host from uri, dispatch HDFS credentials to 
      * segments.
      *
    - * The function uses a hdfs uri in the form hdfs://host:port/ where
    - * port is hard-coded 8020. For HA the function uses hdfs://nameservice/
    + * The function uses a hdfs uri in the form hdfs://host:port/path where
    + * this value is taken from pg_filespace_entry which is populated
    + * based on hawq-site.xml's hawq_dfs_url entry.
      *
      * prepareDispatchedCatalogFileSystemCredential will store the token
    - * using port == 0 in HA case (otherwise the supplied port)
    - *
    - * TODO Get HDFS port from someplace else, currently hard coded
    + * using port == 0 in HA case (otherwise the supplied port).
      */
     static void AddFileSystemCredentialForPxfTable(char *uri)
     {
    -	StringInfoData hdfs_uri;
    +	char* dfs_address = NULL;
     
    -	initStringInfo(&hdfs_uri);
    -	GPHDUri *gphd_uri = parseGPHDUri(uri);
    -    if (gphd_uri->ha_nodes)
    -        appendStringInfo(&hdfs_uri, "hdfs://%s/", gphd_uri->ha_nodes->nameservice);
    -    else
    -        appendStringInfo(&hdfs_uri, "hdfs://%s:8020/", gphd_uri->host);
    +	if (!enable_secure_filesystem)
    --- End diff --
    
    Surprisingly, no. The check was only done inside prepareDispatchedCatalogFileSystemCredential(),
which this function calls.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message