hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hornn <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: Fix 'hawq' issue for OSX after Python...
Date Fri, 15 Jan 2016 00:17:17 GMT
Github user hornn commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/269#discussion_r49806221
  
    --- Diff: tools/bin/generate-greenplum-path.sh ---
    @@ -56,26 +56,26 @@ if [ -h \${GPHOME}/../hawq ]; then
     fi
     EOF
     
    -# OSX does not need JAVA_HOME 
    +# OSX does NOT have DYLD_LIBRARY_PATH, add it
     if [ "${PLAT}" = "Darwin" ] ; then
    -cat << EOF
    -PATH=\$GPHOME/bin:\$GPHOME/ext/python/bin:\$PATH
    -DYLD_LIBRARY_PATH=\$GPHOME/lib:\$GPHOME/ext/python/lib:\$DYLD_LIBRARY_PATH
    +    cat << EOF
    --- End diff --
    
    remove spaces, it's confusing because the other lines in the if block don't have them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message