hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wangzw <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: HAWQ-316. Rework SSE42 implementation...
Date Tue, 05 Jan 2016 07:24:58 GMT
Github user wangzw commented on the pull request:

    https://github.com/apache/incubator-hawq/pull/242#issuecomment-168922445
  
    The patch is generally OK but I have some concerns.
    
    1) Do we have test case for CRC calculation?
    2) By default the checksum verify for interconnect module is disable, but we do not have
test case for CRC enable interconnect. It make code change unsafe.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message