hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hornn <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: HAWQ-293. Enable writable external ta...
Date Tue, 05 Jan 2016 04:40:12 GMT
Github user hornn commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/229#discussion_r48811850
  
    --- Diff: src/backend/commands/tablecmds.c ---
    @@ -17666,6 +17666,12 @@ static Datum transformExecOnClause(List	*on_clause, int *preferred_segment_num)
     		}
     		else if (strcmp(defel->defname, "master") == 0)
     		{
    +			if(iswritable){
    +			  ereport(ERROR,
    +	 	      (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
    +			    errmsg("the ON master syntax for writable external tables is deprecated"),
    --- End diff --
    
    Thank you for the clarification. I meant an errhint() in the ereport message.
    Something like
       ereport(ERROR,
    	 	      (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
    			    errmsg("the ON master syntax for writable external tables is deprecated"),
                                errhint("Only ON number is allowed, where number is the number
of segments"),
    		      errOmitLocation(true)));


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message