hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Wen Lin <w...@pivotal.io>
Subject Re: Adjusting license headers
Date Wed, 30 Dec 2015 02:00:20 GMT
Thank you, Roman!
Once you finish review, I will modify them together.

On Tue, Dec 29, 2015 at 3:13 PM, Roman Shaposhnik <roman@shaposhnik.org>
wrote:

> Hi!
>
> I've committed my patch on top of the latest master.
> I think we're really close to getting done with all this!
>
> Thanks for adjusting the pom file. One thing I've noticed
> while reviewing that change is that I actually need
> to review it more ;-)
>
> Basically, it boils down to things like:
>
> https://github.com/apache/incubator-hawq/commit/c9fc57a3a32d7ec9f522ec5936027d6be290e553#diff-a27afae6b1039ded0f71ad9967e1c67eL2
>
> being absolutely THE RIGHT thing to do, while
> things like:
>
> https://github.com/apache/incubator-hawq/commit/c9fc57a3a32d7ec9f522ec5936027d6be290e553#diff-b012d7bca7f50ded58242c01ffa5c52b
>
> does NOT look right to me.
>
> The difference boils down to files that contain code
> that originated from Greenplum/EMC/Pivotal vs.
> files that are unchanged between HAWQ and
> PostgreSQL.
>
> Give me a day or two to review a bit further. We're
> not quite out of the woods yet, but we're REALLY close.
>
> Thanks,
> Roman.
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message