hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From huor <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: HAWQ-295. New metadata flush strategy...
Date Wed, 30 Dec 2015 09:44:04 GMT
Github user huor commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/231#discussion_r48594711
  
    --- Diff: src/backend/cdb/cdbmetadatacache_process.c ---
    @@ -443,7 +443,7 @@ ProcessMetadataCacheCheck()
                 DestroyHdfsFileInfo(file_info);
                 total_remove_files++;
     
    -            double cache_entry_ratio = hash_get_num_entries(MetadataCache) / metadata_cache_max_hdfs_file_num;
    +            double cache_entry_ratio = (hash_get_num_entries(MetadataCache) * 1.0) /
metadata_cache_max_hdfs_file_num;
    --- End diff --
    
    It would be better to use:
    double cache_entry_ratio = ((double) hash_get_num_entries(MetadataCache)) / metadata_cache_max_hdfs_file_num;


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message