hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From liming01 <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: HAWQ-273. Need re-fetch snapshot at p...
Date Thu, 24 Dec 2015 07:47:29 GMT
Github user liming01 commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/211#discussion_r48400788
  
    --- Diff: src/backend/tcop/postgres.c ---
    @@ -1645,7 +1645,7 @@ exec_simple_query(const char *query_string, const char *seqServerHost,
int seqSe
     		querytree_list = pg_analyze_and_rewrite(parsetree, query_string,
     												NULL, 0);
     
    -		plantree_list = pg_plan_queries(querytree_list, NULL, false, QRL_ONCE);
    +		plantree_list = pg_plan_queries(querytree_list, NULL, true, QRL_ONCE);
     
    --- End diff --
    
    The comment is confusing, it just describes the details about implementation of this function,
instead of describing the API parameter constraint. The logic of skipping snapshot for the
utility statements is inside pg_plan_queries(). So it is no problem. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message