hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wangzw <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: HAWQ-255: change CHECKPOINT_START_LOC...
Date Thu, 17 Dec 2015 07:44:39 GMT
Github user wangzw commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/191#discussion_r47877332
  
    --- Diff: src/backend/access/transam/xact.c ---
    @@ -2317,14 +2317,14 @@ CommitTransaction(void)
     	willHaveObjectsFromSmgr =
     			PersistentEndXactRec_WillHaveObjectsFromSmgr(EndXactRecKind_Commit);
     
    -	if (willHaveObjectsFromSmgr)
    -	{
    -		/*
    -		 * We need to ensure the recording of the [distributed-]commit record and the
    -		 * persistent post-commit work will be done either before or after a checkpoint.
    -		 */
    -		CHECKPOINT_START_LOCK;
    -	}
    --- End diff --
    
    I have some concern about removing this lock. As the comment indicated, what will happen
in such case?
    
    1) flush commit record.
    2) start a checkpoint.
    3) persistent post-commit work (change persistent table)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message