hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shivzone <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: HAWQ-191. Remove Analyzer plugin from...
Date Mon, 14 Dec 2015 23:20:31 GMT
Github user shivzone commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/174#discussion_r47574985
  
    --- Diff: pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/rest/InvalidPathResource.java
---
    @@ -153,9 +167,39 @@ private String parseVersion(String path) {
         }
     
         /**
    +     * Parses the version part from the path.
    --- End diff --
    
    These are private methods used only by wrongPath(). Having an enum and separate function
seems to be an overkill for this. will do away with helper functions and use pathSegments
directly to extract the version and endpoint.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message