hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hornn <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: HAWQ-191. Remove Analyzer plugin from...
Date Mon, 14 Dec 2015 22:55:15 GMT
Github user hornn commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/174#discussion_r47572138
  
    --- Diff: pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/rest/InvalidPathResource.java
---
    @@ -153,9 +167,39 @@ private String parseVersion(String path) {
         }
     
         /**
    +     * Parses the version part from the path.
    --- End diff --
    
    1. Please update doc - it parses the part after the version part, right? /pxf/version/endpoint
    2. could you please refactor parseVersion() to also use PathSegment? 
    Actually, both functions can perhaps be consolidated. [e.g. parsePathSegment(path, VERSION),
parsePath(path, ENDPOINT)]


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message