hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From huor <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: HAWQ-192. Update libyarn proto files ...
Date Tue, 08 Dec 2015 08:38:13 GMT
Github user huor commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/153#discussion_r46926753
  
    --- Diff: depends/libyarn/sample/c_client_main.c ---
    @@ -67,13 +67,13 @@ int main() {
     				printf("2. allocateResources, errorMessage:%s\n",errorMessage);
     		}
     
    -		int32_t activeContainerIds[allocatedResourceArraySize];
    -		int32_t releaseContainerIds[allocatedResourceArraySize];
    -		int32_t statusContainerIds[allocatedResourceArraySize];
    +		int64_t activeContainerIds[allocatedResourceArraySize];
    +		int64_t releaseContainerIds[allocatedResourceArraySize];
    +		int64_t statusContainerIds[allocatedResourceArraySize];
     		printf("2. allocateResources, allocatedResourceArraySize:%d\n", allocatedResourceArraySize);
     		for (i = 0 ; i < allocatedResourceArraySize; i++) {
     			puts("----------------------------");
    -			printf("allocatedResourcesArray[i].containerId:%d\n", allocatedResourcesArray[i].containerId);
    +			printf("allocatedResourcesArray[i].containerId:%ld\n", allocatedResourcesArray[i].containerId);
    --- End diff --
    
    It would be better to have INT64_FORMAT instead of %ld, %dlld, etc.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message