Mailing-List: contact dev-help@hawq.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hawq.incubator.apache.org
From: entong <git@git.apache.org>
To: dev@hawq.incubator.apache.org
Reply-To: dev@hawq.incubator.apache.org
References: <git-pr-92-incubator-hawq@git.apache.org>
In-Reply-To: <git-pr-92-incubator-hawq@git.apache.org>
Subject: [GitHub] incubator-hawq pull request: Analyze HAWQ-44
Content-Type: text/plain
Message-Id: <20151114000015.0430EE045B@git1-us-west.apache.org>
Date: Sat, 14 Nov 2015 00:00:14 +0000 (UTC)

Github user entong commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/92#discussion_r44848062
  
    --- Diff: src/backend/commands/analyze.c ---
    @@ -1217,18 +1214,18 @@ static float4 estimateSampleSize(Oid relationOid, const char *attributeName, flo
      * 	read_only - is it a read-only call?
      * 	tcount - execution tuple-count limit, or 0 for none
      * 	callbackFn - callback function to be executed once SPI is done.
    - * 	clientData - argument to call back function (usually pointer to data-structure 
    + * 	clientData - argument to call back function (usually pointer to data-structure
      * 				that the callback function populates).
    - * 
    + *
      */
    -static void spiExecuteWithCallback(
    +void spiExecuteWithCallback(
     		const char *src,
     		bool read_only,
     		long tcount,
     		spiCallback callbackFn,
     		void *clientData)
     {
    -	bool connected = false;
    +	volatile bool connected = false; /* needs to be volatile when accessed by PG_CATCH */
    --- End diff --
    
    thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---