Return-Path: X-Original-To: apmail-hawq-dev-archive@minotaur.apache.org Delivered-To: apmail-hawq-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AB36A1892F for ; Tue, 10 Nov 2015 07:33:08 +0000 (UTC) Received: (qmail 14446 invoked by uid 500); 10 Nov 2015 07:33:08 -0000 Delivered-To: apmail-hawq-dev-archive@hawq.apache.org Received: (qmail 14388 invoked by uid 500); 10 Nov 2015 07:33:08 -0000 Mailing-List: contact dev-help@hawq.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hawq.incubator.apache.org Delivered-To: mailing list dev@hawq.incubator.apache.org Received: (qmail 14377 invoked by uid 99); 10 Nov 2015 07:33:08 -0000 Received: from Unknown (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Nov 2015 07:33:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id EB779180A25 for ; Tue, 10 Nov 2015 07:33:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.029 X-Spam-Level: X-Spam-Status: No, score=-0.029 tagged_above=-999 required=6.31 tests=[RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id tp4xOg9m0SbC for ; Tue, 10 Nov 2015 07:32:57 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with SMTP id 2B02A20313 for ; Tue, 10 Nov 2015 07:32:56 +0000 (UTC) Received: (qmail 14305 invoked by uid 99); 10 Nov 2015 07:32:55 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Nov 2015 07:32:55 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 46BEBDFC80; Tue, 10 Nov 2015 07:32:55 +0000 (UTC) From: huor To: dev@hawq.incubator.apache.org Reply-To: dev@hawq.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-hawq pull request: HAWQ-117. Add query dispatching conte... Content-Type: text/plain Message-Id: <20151110073255.46BEBDFC80@git1-us-west.apache.org> Date: Tue, 10 Nov 2015 07:32:55 +0000 (UTC) Github user huor commented on the pull request: https://github.com/apache/incubator-hawq/pull/75#issuecomment-155345237 The fix looks good to me. It would be better if the minor revision regarding indention can be fixed. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---