hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jiny2 <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: HAWQ-177. finalize resource queue ddl...
Date Wed, 25 Nov 2015 03:32:14 GMT
Github user jiny2 commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/127#discussion_r45826303
  
    --- Diff: src/backend/resourcemanager/resqueuemanager.c ---
    @@ -1065,16 +1070,27 @@ int checkAndCompleteNewResourceQueueAttributes(DynResourceQueue
 queue,
     		parenttrack = getQueueTrackByQueueOID(queue->ParentOID, &exist);
     		Assert(exist && parenttrack != NULL);
     
    -		/* pg_default can not be a parent queue. */
    +		/* pg_default cannot be a parent queue. */
     		if ( RESQUEUE_IS_DEFAULT(parenttrack->QueueInfo) )
     		{
     			res = RESQUEMGR_WRONG_ATTR;
     			snprintf(errorbuf, errorbufsize,
    -					 "%s can not have children resource queues.",
    +					 "%s cannot have children resource queues",
     					 RESOURCE_QUEUE_DEFAULT_QUEUE_NAME);
     			ELOG_ERRBUF_MESSAGE(WARNING, errorbuf)
     			return res;
     		}
    +
    +		/* The parent queue cannot have roles assigned. */
    +		if ( hasUserAssignedToQueue(parenttrack->QueueInfo) )
    +		{
    +			res = RESQUEMGR_WRONG_ATTR;
    +			snprintf(errorbuf, errorbufsize,
    +					 "%s has at least one role assigned",
    +					 parenttrack->QueueInfo->Name);
    --- End diff --
    
    I prefer using the message which explain the error reason.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message