hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hornn <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: Analyze HAWQ-44
Date Tue, 17 Nov 2015 00:48:49 GMT
Github user hornn commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/92#discussion_r45008425
  
    --- Diff: pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/ReadBridge.java ---
    @@ -14,58 +14,81 @@
     
     import java.io.*;
     import java.nio.charset.CharacterCodingException;
    +import java.util.LinkedList;
     import java.util.zip.ZipException;
     
    -/*
    - * ReadBridge class creates appropriate accessor and resolver.
    - * It will then create the correct output conversion
    - * class (e.g. Text or GPDBWritable) and get records from accessor,
    - * let resolver deserialize them and reserialize them using the
    - * output conversion class.
    - *
    - * The class handles BadRecordException and other exception type
    - * and marks the record as invalid for GPDB.
    +/**
    + * ReadBridge class creates appropriate accessor and resolver. It will then
    + * create the correct output conversion class (e.g. Text or GPDBWritable) and
    + * get records from accessor, let resolver deserialize them and reserialize them
    + * using the output conversion class. <br>
    + * The class handles BadRecordException and other exception type and marks the
    + * record as invalid for HAWQ.
      */
     public class ReadBridge implements Bridge {
         ReadAccessor fileAccessor = null;
         ReadResolver fieldsResolver = null;
         BridgeOutputBuilder outputBuilder = null;
    +    LinkedList<Writable> outputQueue = null;
     
    -    private Log Log;
    +    static private Log Log = LogFactory.getLog(ReadBridge.class);
    --- End diff --
    
    Good point. 
    Also created JIRA to change it all over the code https://issues.apache.org/jira/browse/HAWQ-165


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message