hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hornn <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: Analyze HAWQ-44
Date Fri, 13 Nov 2015 16:51:12 GMT
Github user hornn commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/92#discussion_r44804907
  
    --- Diff: src/backend/access/external/hd_work_mgr.c ---
    @@ -216,51 +216,50 @@ static void assign_pxf_port_to_fragments(int remote_rest_port, List
*fragments)
     }
     
     /*
    - * Fetches statistics of the PXF datasource from the PXF service
    + * Fetches fragments statistics of the PXF datasource from the PXF service
      *
    - * The function will generate a delegation token when secure filesystem mode 
    + * The function will generate a delegation token when secure filesystem mode
      * is on and cancel it right after.
      */
    -PxfStatsElem *get_pxf_statistics(char *uri, Relation rel, StringInfo err_msg)
    +PxfFragmentStatsElem *get_pxf_fragments_statistics(char *uri, Relation rel, StringInfo
err_msg)
    --- End diff --
    
    I will check.
    If I remember correctly, the reason for this behaviour is that we don't want to error
out in case analyze on external fails, but only to issue a warning, and continue to analyze
the next tables. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message