hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shivzone <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: Analyze HAWQ-44
Date Thu, 12 Nov 2015 22:12:34 GMT
Github user shivzone commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/92#discussion_r44722757
  
    --- Diff: pxf/pxf-hdfs/src/main/java/org/apache/hawq/pxf/plugins/hdfs/HdfsDataFragmenter.java
---
    @@ -43,19 +46,11 @@ public HdfsDataFragmenter(InputData md) {
         @Override
         public List<Fragment> getFragments() throws Exception {
             String absoluteDataPath = HdfsUtilities.absoluteDataPath(inputData.getDataSource());
    -        InputSplit[] splits = getSplits(new Path(absoluteDataPath));
    +        ArrayList<InputSplit> splits = getSplits(new Path(absoluteDataPath));
    --- End diff --
    
    Use Interface List here instead of ArrayList ... just a best practice


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message