hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From entong <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: Analyze HAWQ-44
Date Thu, 12 Nov 2015 20:09:47 GMT
Github user entong commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/92#discussion_r44707837
  
    --- Diff: src/backend/commands/analyze.c ---
    @@ -1436,7 +1431,7 @@ static Oid buildSampleTable(Oid relationOid,
     /**
      * Drops the sample table created during ANALYZE.
      */
    -static void dropSampleTable(Oid sampleTableOid)
    +void dropSampleTable(Oid sampleTableOid, bool isExternal)
    --- End diff --
    
    I'm confused here. The sample table we created, even for pxf, is a regular AO table. Why
we use 'drop external table' here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message