hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From entong <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: Analyze HAWQ-44
Date Thu, 12 Nov 2015 19:55:10 GMT
Github user entong commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/92#discussion_r44706061
  
    --- Diff: src/backend/commands/analyze.c ---
    @@ -933,13 +914,12 @@ static void analyzeRelation(Relation relation, List *lAttributeNames,
bool rooto
     	else
     	{
     		initStringInfo(&err_msg);
    -		gp_statistics_estimate_reltuples_relpages_external_pxf(relation, &location, &estimatedRelTuples,
&estimatedRelPages, &err_msg);
    +		analyzePxfEstimateReltuplesRelpages(relation, &location, &estimatedRelTuples,
&estimatedRelPages, &err_msg);
     		if (err_msg.len > 0)
     		{
    -			ereport(WARNING,
    -					(errmsg("skipping \"%s\" --- error returned: %s",
    -							RelationGetRelationName(relation),
    -							err_msg.data)));
    +			elog(ERROR,
    +					"%s",
    +					err_msg.data);
    --- End diff --
    
    If an error occurs, do we abort the entire analyze?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message