Return-Path: X-Original-To: apmail-hawq-dev-archive@minotaur.apache.org Delivered-To: apmail-hawq-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C7B8E1875F for ; Tue, 20 Oct 2015 03:03:08 +0000 (UTC) Received: (qmail 24677 invoked by uid 500); 20 Oct 2015 03:03:07 -0000 Delivered-To: apmail-hawq-dev-archive@hawq.apache.org Received: (qmail 24624 invoked by uid 500); 20 Oct 2015 03:03:07 -0000 Mailing-List: contact dev-help@hawq.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hawq.incubator.apache.org Delivered-To: mailing list dev@hawq.incubator.apache.org Received: (qmail 24613 invoked by uid 99); 20 Oct 2015 03:03:06 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Oct 2015 03:03:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 2F7D8C58EC for ; Tue, 20 Oct 2015 03:03:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.982 X-Spam-Level: X-Spam-Status: No, score=0.982 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id lVRgyq48BbbY for ; Tue, 20 Oct 2015 03:02:58 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with SMTP id 9015E205E9 for ; Tue, 20 Oct 2015 03:02:58 +0000 (UTC) Received: (qmail 24603 invoked by uid 99); 20 Oct 2015 03:02:58 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Oct 2015 03:02:58 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 16F9EE09B8; Tue, 20 Oct 2015 03:02:58 +0000 (UTC) From: jianlirong To: dev@hawq.incubator.apache.org Reply-To: dev@hawq.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-hawq pull request: HAWQ-68. Wrong answer when converting... Content-Type: text/plain Message-Id: <20151020030258.16F9EE09B8@git1-us-west.apache.org> Date: Tue, 20 Oct 2015 03:02:58 +0000 (UTC) Github user jianlirong commented on the pull request: https://github.com/apache/incubator-hawq/pull/29#issuecomment-149413822 As the JIRA description suggested, the strategy of this fix is to let the partition child table with the largest data size decide whether all other partition child tables should be transformed from hash to random. According to this definition, this fix is OK to me. +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---