hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From radarwave <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: HAWQ-109. Fix exit code of hawq comma...
Date Fri, 30 Oct 2015 05:53:09 GMT
Github user radarwave commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/59#discussion_r43473683
  
    --- Diff: tools/bin/hawq ---
    @@ -51,71 +57,69 @@ def main():
                 print START_HELP
                 sys.exit(1)
             cmd = "%s; hawq_ctl %s %s" % (source_hawq_env, hawq_command, sub_args)
    -        local_ssh(cmd)
    +        result = local_ssh(cmd)
         elif hawq_command == "stop":
             if second_arg not in cluster_type_list:
                 print STOP_HELP
                 sys.exit(1)
             cmd = "%s; hawq_ctl %s %s" % (source_hawq_env, hawq_command, sub_args)
    -        local_ssh(cmd)
    +        result = local_ssh(cmd)
         elif hawq_command == "init":
             if second_arg not in cluster_init_list:
                 print INIT_HELP
                 sys.exit(1)
             cmd = "%s; hawq_ctl %s %s" % (source_hawq_env, hawq_command, sub_args)
    -        local_ssh(cmd)
    +        result = local_ssh(cmd)
         elif hawq_command == "restart":
             if second_arg not in cluster_type_list:
                 print START_HELP
                 sys.exit(1)
             cmd = "%s; hawq_ctl stop %s" % (source_hawq_env, sub_args)
    -        local_ssh(cmd)
    +        result = local_ssh(cmd)
    --- End diff --
    
    Thanks Noa, for this one I intend to do so, I want restart can continue if some of the
segments already been shutdown before this restart. Sure we can have another Jira to track
and discuss of such behavior.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message