hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hornn <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: HAWQ-109. Fix exit code of hawq comma...
Date Thu, 29 Oct 2015 11:29:10 GMT
Github user hornn commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/59#discussion_r43373963
  
    --- Diff: tools/bin/hawq_ctl ---
    @@ -886,24 +897,47 @@ def hawq_activate_standby(opts, hawq_dict):
         if result != 0:
             logger.debug("Stop cluster failed, try to stop it immediately.")
             cmd = "%s; hawq stop cluster -a -M immediate;" % source_hawq_env
    -        local_ssh(cmd)
    +        result = local_ssh(cmd)
    +        if result != 0:
    +            logger.error("Stop cluster failed, exit.")
    +            sys.exit(1)
         cmd = "%s; hawq config -c hawq_master_address_host -v %s --skipvalidation -q" % (source_hawq_env,
hawq_dict['hawq_standby_address_host'])
    -    local_ssh(cmd)
    +    result = local_ssh(cmd)
    +    if result != 0:
    +        logger.error("Set hawq_master_address_host  failed.")
    --- End diff --
    
    extra space before "failed"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message