hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jiny2 <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: HAWQ-47. Make user able to set statem...
Date Mon, 26 Oct 2015 11:07:22 GMT
Github user jiny2 commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/34#discussion_r42980390
  
    --- Diff: src/backend/resourcemanager/communication/rmcomm_QD2RM.c ---
    @@ -374,20 +374,24 @@ int cleanupQD2RMComm(void)
             {
                 if ( QD2RM_ResourceSets[i]->QD_ResourceList != NULL )
                 {
    -                elog( LOG, "Un-returned resource is probed, will be returned. "
    -                        "(%d MB, %lf CORE) x %d. Conn ID=%d",
    -                        QD2RM_ResourceSets[i]->QD_SegMemoryMB,
    -                        QD2RM_ResourceSets[i]->QD_SegCore,
    -                        QD2RM_ResourceSets[i]->QD_SegCount,
    -                        QD2RM_ResourceSets[i]->QD_Conn_ID);
    +                elog(LOG, "Un-returned resource is probed, will be returned. "
    +                          "(%d MB, %lf CORE) x %d. Conn ID=%d",
    +                          QD2RM_ResourceSets[i]->QD_SegMemoryMB,
    +                          QD2RM_ResourceSets[i]->QD_SegCore,
    +                          QD2RM_ResourceSets[i]->QD_SegCount,
    +                          QD2RM_ResourceSets[i]->QD_Conn_ID);
     
                     res = returnResource(i, errorbuf, sizeof(errorbuf));
    -                if ( res != FUNC_RETURN_OK ) {
    -                	elog(LOG, "Fail to return resource when cleaning up resource context.");
    +                if ( res != FUNC_RETURN_OK )
    +                {
    +                	elog(WARNING, "Failed to return resource when cleaning up "
    +                				  "resource context.");
    --- End diff --
    
    I did not find the mismatch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message