hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cwelton <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: HAWQ-25. Add resource queue new ddl s...
Date Tue, 13 Oct 2015 06:34:42 GMT
Github user cwelton commented on a diff in the pull request:

    --- Diff: src/backend/commands/user.c ---
    @@ -554,31 +541,34 @@ CreateRole(CreateRoleStmt *stmt)
     	if (resqueue)
    -		if (strcmp(resqueue, "none") == 0) {
    +		if (strcmp(resqueue, "none") == 0)
    +		{
    -					 errmsg("resource queue name \"%s\" is reserved",
    +					 errmsg("Resource queue name \"%s\" is reserved",
    --- End diff --
    I agree with Lirong, the old message conforms to error message guidelines and is preferable
to the replacement.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message