hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jianlirong <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: HAWQ-25. Add resource queue new ddl s...
Date Mon, 12 Oct 2015 08:16:13 GMT
Github user jianlirong commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/17#discussion_r41733033
  
    --- Diff: src/backend/commands/user.c ---
    @@ -554,31 +541,34 @@ CreateRole(CreateRoleStmt *stmt)
     
     	if (resqueue)
     	{
    -		if (strcmp(resqueue, "none") == 0) {
    +		if (strcmp(resqueue, "none") == 0)
    +		{
     			unregisterConnectionInRMWithErrorReport(resourceid);
     			releaseResourceContextWithErrorReport(resourceid);
     			ereport(ERROR,
     					(errcode(ERRCODE_RESERVED_NAME),
    -					 errmsg("resource queue name \"%s\" is reserved",
    +					 errmsg("Resource queue name \"%s\" is reserved",
    --- End diff --
    
    According to the PostgreSQL Error Message Style Guide, "Do not capitalize the first letter".
I think here the old one is better than the new one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message